Added additional Xtend validator tests #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@szarnekow I'll probably add further tests while working on #2349 so I'd wait before merging this. |
|
I'm also verifying the position of the error marker to ensure I'm not breaking anything with the refactoring |
LorenzoBettini
changed the title
|
I'm closing this for now and just push the branch to avoid overloading GitHub Actions |
|
I forgot that we don't build our PRs, so I'm re-opening |
LorenzoBettini
force-pushed
the
lb_xtend_validator_tests
branch
from
b5a41cb
to
af65508
Compare
LorenzoBettini
force-pushed
the
lb_xtend_validator_tests
branch
from
e424b1a
to
365f1fa
Compare
|
I like the updated tests |
szarnekow
approved these changes
Jan 8, 2024
|
@szarnekow glad you like them :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
while working on #2349 I noted that some situations were not tested