Added IterableExtensions.lastOrNull and deprecated last #2983
Conversation
gwt-maven plugin: The attribute since is undefined for the annotation type Deprecated
| @@ -87,7 +87,7 @@ protected Integer findLast(Iterable<Integer> input, Function1<Integer, Boolean> | |||
|
|
|||
| @Override | |||
| protected Integer last(Iterable<Integer> input) { | |||
There was a problem hiding this comment.
Can you please rename this method last also to lastOrNull?
There was a problem hiding this comment.
@szarnekow this method is defined as abstract in the superclass org.eclipse.xtext.xbase.tests.lib.BaseIterablesIteratorsTest.last(IterableOrIterator) so I should rename it also in IteratorExtensionsTest.
I changed to lastOrNull only in IterableExtensions, NOT in IteratorExtensions.
There was a problem hiding this comment.
Yes, I saw that. I wonder if we should both keep in symmetry, though. Thoughts?
There was a problem hiding this comment.
I also thought about that, but how do we "justify" the deprecation for IteratorExtensions? Of course, we could use the "symmetry" justification.
Also head could be changed accordingly.
Unfortunately, we are forced to change IterableExtensions.last only for the clash with Java 21 new API.
There was a problem hiding this comment.
So far I liked that the extension API for iterables and iterators was equivalent (as far as it goes).
There was a problem hiding this comment.
Ok, then I'll add lastOrNull to IteratorExtensions and update this PR
|
@szarnekow I've added when the build is green, I'll merge |
Closes #2981
I have updated the occurrences in our code base, but NOT in the input files of our tests.