Add AbstractXtextTests in .xtext.testing
#3038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from the one in .xtext.tests
there are no Xtend tests in this project anymore
cdietrich
reviewed
May 15, 2024
org.eclipse.xtext.testing/src/org/eclipse/xtext/testing/AbstractXtextTests.java
Show resolved
Hide resolved
|
@cdietrich so do you want me to mark it as beta or is the PR ok? |
|
i want to be safe and thus mark it as beta |
|
@cdietrich done: d10ede9 |
szarnekow
reviewed
May 16, 2024
| */ | ||
| public abstract class AbstractXtextTests extends Assert implements ResourceLoadHelper { | ||
| @Beta |
There was a problem hiding this comment.
I'd appreciate a comment that points to the "newer" way of writing tests based on @RunWith and friends.
There was a problem hiding this comment.
@szarnekow Right! To think I also thought about that and then forgot it ;)
Done that here f6a299a
I also took the chance to clean a few other bits.
szarnekow
approved these changes
May 16, 2024
cdietrich
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for #3026.
AbstractXtextTestsis now in.xtext.testing.It doesn't implement
ResourceLoadHelperanymore: it wasn't used in a headless context. In fact,ResourceLoadHelperhad already been inserted in.xtext.ui.testing.The current
AbstractXtextTestshas been taken from duplicate occurrences of our test projects.In some cases, the
implements ResourceLoadHelperhad to be manually added for some of our older content assist tests. But that wasn't a big deal.