Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize plugins #29

Closed
angelozerr opened this issue Sep 29, 2016 · 8 comments
Closed

Reorganize plugins #29

angelozerr opened this issue Sep 29, 2016 · 8 comments

Comments

@angelozerr
Copy link
Contributor

org.eclipse.languageserver should be spliited into several plugins:

  • org.eclipse.languageserver.core
  • org.eclipse.languageserver.ui
  • org.eclipse.languageserver.csharp.core
  • org.eclipse.languageserver.csharp.ui
  • org.eclipse.languageserver.json.core
  • org.eclipse.languageserver.json.ui
  • org.eclipse.languageserver.css.core
  • org.eclipse.languageserver.css.ui
@mickaelistria
Copy link
Contributor

Can you please elaborate about what would be the content of each of these bundles? I'm unsure splitting core and ui is meaningful there, as this integration has for sole goal to integrate language server in UI.

@mickaelistria
Copy link
Contributor

Commit 2c58077 does extract the language-specific parts to a separated plugin. So everything inside the org.eclipse.languageserver bundle is totally independent from actual instances of language servers.

@angelozerr
Copy link
Contributor Author

Thanks @mickaelistria !

Once the launch topic will be clear, we will able to to split org.eclipse.languageserver.languages into:

  • org.eclipse.languageserver.languages.csharp
  • org.eclipse.languageserver.languages.json
  • org.eclipse.languageserver.languages.css

and find a solution to contribute to launch. This split will help the dev of another language (I'm experimenting for TypeScript).

@mickaelistria
Copy link
Contributor

Does typescript server implement the language server protocol?

@angelozerr
Copy link
Contributor Author

No, I'm trying to study it. If it's not complex I will implement it.

@mickaelistria
Copy link
Contributor

Get in touch with the Typescript and VSCode people first. I know they plan to ship one together with the regular typescript tools. I can't tell about progress, status nor ETA.
Implementing a language server is going to take some time, and if TypeScript release an official one, yours will be entirely eclipsed by the official one. I'm not sure it's a bankable way to spend resources right now.

@mickaelistria
Copy link
Contributor

I've opened microsoft/TypeScript#11274

@mickaelistria mickaelistria changed the title Split org.eclipse.languageserver into several Core/UI plugins Reorganize plugins Oct 15, 2016
@mickaelistria
Copy link
Contributor

Closing as this is not really an issue at the moment. We'll probably have to reconsider how the "languages" bundle is organized as LSP4E or downstream project start shipping actual support for languages with existing language servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants