Update data via lodash's fp/set

Use lodahs's "fp/set" instead of "cloneDeep" to increase performance
for data updates, especially for larger models.

Previously JSON Forms used lodash's "cloneDeep" to create a copy
of the current data and then update the relevant parts. This has the
benefit of being a guaranteed immutable update, however it's an
expensive process and hinders using shallow compare on data
objects which were not touched. We now use "fp/set" as a
compromise: It will create new objects for all elements directly
containing the updated data, while leaving sibling elements
alone. This increases performance a lot while still triggering
updates for the changed objects.

packages/core/src/reducers/core.ts

@@ -1,19 +1,19 @@
 /*
   The MIT License
-  
+
   Copyright (c) 2017-2019 EclipseSource Munich
   https://github.com/eclipsesource/jsonforms
-  
+
   Permission is hereby granted, free of charge, to any person obtaining a copy
   of this software and associated documentation files (the "Software"), to deal
   in the Software without restriction, including without limitation the rights
   to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
   copies of the Software, and to permit persons to whom the Software is
   furnished to do so, subject to the following conditions:
-  
+
   The above copyright notice and this permission notice shall be included in
   all copies or substantial portions of the Software.
-  
+
   THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
   IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
   FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
@@ -23,7 +23,7 @@
   THE SOFTWARE.
 */
 import cloneDeep from 'lodash/cloneDeep';
-import set from 'lodash/set';
+import setFp from 'lodash/fp/set';
 import get from 'lodash/get';
 import filter from 'lodash/filter';
 import isEqual from 'lodash/isEqual';
@@ -270,9 +270,7 @@ export const coreReducer: Reducer<JsonFormsCore, CoreActions> = (
       } else if (action.path === '') {
         // empty path is ok
         const result = action.updater(cloneDeep(state.data));
-
         const errors = sanitizeErrors(state.validator, result);
-
         return {
           ...state,
           data: result,
@@ -281,9 +279,12 @@ export const coreReducer: Reducer<JsonFormsCore, CoreActions> = (
       } else {
         const oldData: any = get(state.data, action.path);
         const newData = action.updater(cloneDeep(oldData));
-        const newState: any = set(state.data === undefined ? {} : cloneDeep(state.data), action.path, newData);
+        const newState: any = setFp(
+          action.path,
+          newData,
+          state.data === undefined ? {} : state.data
+        );
         const errors = sanitizeErrors(state.validator, newState);
-
         return {
           ...state,
           data: newState,

packages/core/test/reducers/core.test.ts

@@ -468,13 +468,18 @@ test('core reducer - update - undefined data should update for given path', t =>
     })
   );
 
+  t.not(before, after);
+  t.not(before.data, after.data);
   t.deepEqual(after, { ...before, data: { foo: 'bar'} });
 });
 
 test('core reducer - update - path is undefined state should remain same', t => {
   const before: JsonFormsCore = {
     data: {
-      foo: 'bar'
+      foo: 'bar',
+      baz: {
+        bar: 'bar'
+      }
     },
     schema: {
       type: 'object',
@@ -493,17 +498,23 @@ test('core reducer - update - path is undefined state should remain same', t =>
   const after = coreReducer(
     before,
     update(undefined, _ => {
-      return { foo: 'xyz' };
+      return { foo: 'anything' };
     })
   );
 
+  t.is(before, after);
+  t.is(before.data, after.data);
+  t.is(before.data.baz, after.data.baz);
   t.deepEqual(before, after);
 });
 
 test('core reducer - update - path is null state should remain same', t => {
   const before: JsonFormsCore = {
     data: {
-      foo: 'bar'
+      foo: 'bar',
+      baz: {
+        bar:'bar'
+      }
     },
     schema: {
       type: 'object',
@@ -522,10 +533,13 @@ test('core reducer - update - path is null state should remain same', t => {
   const after = coreReducer(
     before,
     update(null, _ => {
-      return { foo: 'xyz' };
+      return { foo: 'anything' };
     })
   );
 
+  t.is(before, after);
+  t.is(before.data, after.data);
+  t.is(before.data.baz, after.data.baz);
   t.deepEqual(before, after);
 });
 
@@ -541,7 +555,10 @@ test('core reducer - update - empty path should update root state', t => {
 
   const before: JsonFormsCore = {
     data: {
-      foo: 'bar'
+      foo: 'bar',
+      baz: {
+        bar:'bar'
+      }
     },
     errors: [],
     schema,
@@ -558,6 +575,8 @@ test('core reducer - update - empty path should update root state', t => {
     })
   );
 
+  t.not(before, after);
+  t.not(before.data, after.data);
   t.deepEqual(after, { ...before, data: { foo: 'xyz' } });
 });
 
@@ -577,7 +596,10 @@ test('core reducer - update - providing a path should update data only belonging
   const before: JsonFormsCore = {
     data: {
       animal: 'Sloth',
-      color: 'Blue'
+      color: 'Blue',
+      baz: {
+        bar: 'bar'
+      }
     },
     errors: [],
     schema,
@@ -594,7 +616,10 @@ test('core reducer - update - providing a path should update data only belonging
     })
   );
 
-  t.deepEqual(after, { ...before, data: { animal: 'Sloth', color: 'Green' } });
+  t.not(before, after);
+  t.not(before.data, after.data);
+  t.is(before.data.baz, after.data.baz);
+  t.deepEqual(after, { ...before, data: { ...before.data, color: 'Green' } });
 });
 
 test('core reducer - update - should update errors', t => {
@@ -614,7 +639,7 @@ test('core reducer - update - should update errors', t => {
   const before: JsonFormsCore = {
     data: {
       animal: 'Sloth',
-      color: 'Blue'
+      color: 'Blue',
     },
     errors: [],
     schema,
@@ -633,7 +658,7 @@ test('core reducer - update - should update errors', t => {
 
   t.deepEqual(after, {
     ...before,
-    data: { animal: 'Sloth', color: 'Yellow' },
+    data: { ...before.data, color: 'Yellow' },
     errors: [
       {
         dataPath: 'color',