Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Date Picker Validation #2183

Closed
avwchapman12 opened this issue Oct 5, 2023 · 1 comment · Fixed by #2200
Closed

Date Picker Validation #2183

avwchapman12 opened this issue Oct 5, 2023 · 1 comment · Fixed by #2200
Assignees
@LukasBoll
Labels
bug
Milestone
3.2

Comments

@avwchapman12
Copy link

avwchapman12 commented Oct 5, 2023 •
edited

Describe the bug

When you delete (using the backspace button) an invalid date (whether by the default date format or additional errors such as min or max date), even if the field is not required the invalid date error persists.

Screenshot 2023-10-04 at 12 05 13 PM

Expected behavior

When you delete (using the backspace button) an invalid date (whether by the default date format or additional errors such as min or max date), if the field is not required there is no error showing and the data should be undefined for that input.

Steps to reproduce the issue

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots

Screen Recording 2023-10-05 at 12.21.09 PM.mov

In which browser are you experiencing the issue?

Google Chrome Version 117.0.5938.92

Which Version of JSON Forms are you using?

v3.0.0

Framework

React

RendererSet

Material

Additional context

No response
@sdirix sdirix added the bug label Oct 17, 2023
@sdirix
Copy link
Member

sdirix commented Oct 17, 2023

Thanks for the report. We'll have a look. However instead of null we usually place undefined in the data.

@sdirix sdirix added this to the 3.2 milestone Oct 17, 2023
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Oct 27, 2023
@LukasBoll
fix(material): Improve usability of date renderers
d8902d9 
Set value to 'undefined' if the text input is empty. If the input is
invalid, set the actual value instead of "invalid data" and display the
last input instead of an empty field.

Closes eclipsesource#2183
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Oct 27, 2023
@LukasBoll
fix(material): Improve usability of date renderers
85d995e 
Set value to 'undefined' if the text input is empty. If the input is
invalid, set the actual value instead of "invalid data" and display the
last input instead of an empty field.

Closes eclipsesource#2183
@LukasBoll LukasBoll mentioned this issue Oct 27, 2023
Merged
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Oct 31, 2023
@LukasBoll
fix(material): Improve usability of date renderers
3b41788 
Set value to 'undefined' if the text input is empty. If the input is
invalid, set the actual value instead of "invalid data" and display the
last input instead of an empty field.

Closes eclipsesource#2183 (+1 squashed commits)

Squashed commits:

[bf12c01] fix(material): Improve usability of date renderers

Set value to 'undefined' if the text input is empty. If the input is
invalid, set the actual value instead of "invalid data" and display the
last input instead of an empty field.

Closes eclipsesource#2183
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Nov 6, 2023
@LukasBoll
fix(material): Improve usability of date renderers
f59dec5 
Previously, data wasn't cleared when the input field was emptied.
This commit will set the value to 'undefined' when the input is empty or
invalid upon blurring. During editing, the data is only updated when the
current input is valid.

Closes eclipsesource#2183
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Nov 15, 2023
@LukasBoll
fix(material): Improve usability of date renderers
74de9ae 
Previously, data wasn't cleared when the input field was emptied.
This commit will set the value to 'undefined' when the input is empty or
invalid upon blurring. During editing, the data is only updated when the
current input is valid.

Closes eclipsesource#2183
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Dec 4, 2023
@LukasBoll
fix(material): Improve usability of date renderers
53b5a73 
Previously, data wasn't cleared when the input field was emptied.
This commit will set the value to 'undefined' when the input is empty or
invalid upon blurring. During editing, the data is only updated when the
current input is valid.

Closes eclipsesource#2183
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Dec 20, 2023
@LukasBoll
fix(material): Improve usability of date renderers
dc3c900 
Previously, data wasn't cleared when the input field was emptied.
This commit will set the value to 'undefined' when the input is empty or
invalid upon blurring. During editing, the data is only updated when the
current input is valid.

Closes eclipsesource#2183
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Dec 20, 2023
@LukasBoll
fix(material): Improve usability of date renderers
67e6bdb 
Previously, data wasn't cleared when the input field was emptied.
This commit will set the value to 'undefined' when the input is empty or
invalid upon blurring. During editing, the data is only updated when the
current input is valid.

Closes eclipsesource#2183
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Dec 20, 2023
@LukasBoll
fix(material): Improve usability of date renderers
81fece1 
Previously, data wasn't cleared when the input field was emptied.
This commit will set the value to 'undefined' when the input is empty or
invalid upon blurring. During editing, the data is only updated when the
current input is valid.

Closes eclipsesource#2183
LukasBoll added a commit to LukasBoll/jsonforms that referenced this issue Jan 9, 2024
@LukasBoll
fix(material): Improve usability of date renderers
6e5cffe 
Previously, data wasn't cleared when the input field was emptied.
This commit will set the value to 'undefined' when the input is empty or
invalid upon blurring. During editing, the data is only updated when the
current input is valid.

Closes eclipsesource#2183
sdirix pushed a commit that referenced this issue Jan 22, 2024
@LukasBoll @sdirix
fix(material): Improve usability of date renderers
01b08f0 
Previously, data wasn't cleared when the input field was emptied.
This commit will set the value to 'undefined' when the input is empty or
invalid upon blurring. During editing, the data is only updated when the
current input is valid.

Closes #2183
@sdirix sdirix mentioned this issue Feb 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LukasBoll LukasBoll

Labels
bug
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Fix/datepicker validation LukasBoll/jsonforms
3 participants
@sdirix @LukasBoll @avwchapman12