Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The delete button should be displayed only when an item is hovered and hidden #2327

Closed
stanisev opened this issue Apr 29, 2024 · 1 comment · Fixed by #2330
Closed

The delete button should be displayed only when an item is hovered and hidden #2327

stanisev opened this issue Apr 29, 2024 · 1 comment · Fixed by #2330

Comments

@stanisev
Copy link
Contributor

Describe the bug

The delete button should be displayed only when an item is hovered and hidden (via the hide class) by default which was removed In one of the previous MRs

Expected behavior

We should add back removed hint css class

Steps to reproduce the issue

Use master details renderer. All elements of the master details will have the delete button (delete button should be displayed only on hover)

Screenshots

No response

Which Version of JSON Forms are you using?

v3.2.1

Framework

Angular

RendererSet

Other (please specify in the Additional context field)

Additional context

No response
@stanisev stanisev mentioned this issue Apr 29, 2024
Merged
@JBBianchi
Copy link
Contributor

Little typo hint hide

Discussed in #2229 (comment)

stanisev added a commit to stanisev/jsonforms that referenced this issue May 3, 2024
@stanisev
[FIX-eclipsesource#2327] Revert deletion of hide css class, the delet…
ed6291d 
…e button should be displayed only when an item is hovered and hidden
@coveralls coveralls mentioned this issue May 8, 2024
Merged
@lucas-koehler lucas-koehler linked a pull request May 15, 2024 that will close this issue
[FIX-#2327] Revert deletion of hide css class in process of angular upgrade #2330
Merged
lucas-koehler pushed a commit that referenced this issue May 15, 2024
@stanisev
angular-material: Revert deletion of hide css class
5c5a470 
Revert the deletion of the hide css class in the angular material master detail renderer.
With this, the delete button is displayed only when an item is hovered and hidden.

Fixes #2327
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX-#2327] Revert deletion of hide css class in process of angular upgrade stanisev/jsonforms
2 participants
@stanisev @JBBianchi