-
Notifications
You must be signed in to change notification settings - Fork 359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UiSchema in Jupyter Dialog Box not working at all #2333
Comments
Hi @misterfads, Can you post the |
I have @jsonforms/vanilla-renderers installed, which according to https://jsonforms.io/api/vanilla/globals#horizontallayoutrenderercomponent seems to include some styling for HorizontalLayout. Which makes sense because I did not add any styling for the Group layout to show. So I am a bit confused then on if I need to add more config/css that you mentioned in your previous comment. Here is my schema, uischema, it is from a basic example from the docs.
So it looks something like this, you can see some sort of basic styling got added for the Group, but the HorizontalLayout (street, streetnumber) is still vertical |
Hi @misterfads, The group has some styling as it uses a If you want the horizontal and vertical layouts to work you need to provide the appropriate styles. JSON Forms simply applies a different CSS class to them, besides that they are exactly the same. In the example CSS we use flex-box to orient them horizontally and vertically. Besides that, you already have some customization in place as we don't render these question mark items by default. |
I see, thank you So you're saying I should use a custom layout then as described here? https://jsonforms.io/docs/tutorial/custom-layouts Is there any example anywhere for an example custom renderer for vanilla layouts? |
Ah ok I found https://github.com/eclipsesource/jsonforms/blob/master/packages/vanilla-renderers/Styles.md, providing vanillaStyles in the styleContextValue variable added default vanilla renderer behaviors for layouts So If I want to adjust these default values, do I instead need to create a custom layout renderer with |
Hi @misterfads, Note that all our renderers are the same as "custom renderers". So you can always look through our code base and check how we implemented them. I'll close this issue as the original topic is now answered. I can also recommend checking the community forum for usage questions. |
Describe the bug
I'm currently trying to get a Jsonform to appear inside a Jupyter Lab dialog box. It appears but it seems to completely disregard the uischema I provide. Eg. It just uses the default VerticalLayout for all schema fields everytime, even if I indicate I want certain fields in a horizontal layout. I couldn't find any relevant issue that was similar to this.
Edit: seems like other parts of the uischema like showing/hiding fields with Rule, and groups works, it just refuses to show any Horizontal Layout
Expected behavior
Expect that the json form reflects the uischema I provide
Steps to reproduce the issue
Display a jsonform inside a Jupyter dialog box
Screenshots
No response
Which Version of JSON Forms are you using?
v3.2.1
Framework
React
RendererSet
Vanilla
Additional context
No response
The text was updated successfully, but these errors were encountered: