Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum properties are rendered as regular input instead of select element #64

Closed
muenchdo opened this issue Aug 4, 2015 · 3 comments
Closed
Labels

Comments

@muenchdo
Copy link
Contributor

muenchdo commented Aug 4, 2015

Hi, in the latest version, enum properties are not rendered as select elements, but as regular inputs instead. It still works in the live demo, however the code there seems outdated.

This is probably because in JSONSchema the type of an enum is (I think) always string, but never enum. However in the control template's ng-switch-when, the select input is only rendered when the schemaType equals enum.

I have prepared a pull request which should fix the problem. I will submit it later.

@sdirix
Copy link
Member

sdirix commented Aug 4, 2015

Thanks for your efforts! You are right, currently some of the inputs are broken. I will look into your changes as soon as I can (probably tomorrow).

Welcome to JSONForms ;)

@sdirix
Copy link
Member

sdirix commented Sep 29, 2015

As you may have noticed the renderer was rewritten before we could merge your contribution, so this bug is already fixed ;)

We still would like to integrate your unit test since one can never have enough tests. The more the better!

But before we can merge your unit test you need to sign our CLA. More information can be found in our (new) CONTRIBUTING.md.

Thank you for your work and sorry for the delay. Future contributions will be processed much faster. See you soon ;)

@sdirix
Copy link
Member

sdirix commented Oct 12, 2015

Your unit test was merged in #97.

Thanks for your contribution!

@sdirix sdirix closed this as completed Oct 12, 2015
@sdirix sdirix added the bug label Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants