Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix enum properties not being rendered as select element #65

Closed
wants to merge 2 commits into from
Closed

Fix enum properties not being rendered as select element #65

wants to merge 2 commits into from

Conversation

muenchdo
Copy link
Contributor

@muenchdo muenchdo commented Aug 4, 2015

This should fix #64. Please get back to me if anything is wrong, I haven't made many contributions yet...

Cheers
Dominik

@sdirix
Copy link
Member

sdirix commented Aug 5, 2015

Works like a charm! Thanks for adding a unit test too ;)

+1 for merge!

@sdirix
Copy link
Member

sdirix commented Aug 11, 2015

A short update for you:
We are currently revising the rules for external committers. This is why we did not yet merge your contribution ;) As soon as we are finished (presumably within the next two weeks) we will inform you regarding the next steps.

@muenchdo
Copy link
Contributor Author

Don't worry, it is not urgent ;)

@sdirix sdirix mentioned this pull request Oct 5, 2015
Merged
@sdirix
Copy link
Member

sdirix commented Oct 12, 2015

We cherry-picked your unit test in #97

Thanks for your contribution ;)

@sdirix sdirix closed this Oct 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enum properties are rendered as regular input instead of select element
2 participants
@muenchdo @sdirix