Added support for show/hide rules #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -5,7 +5,7 @@ class NumberRenderer implements JSONForms.IRenderer { | |||
| priority = 2; | |||
|
|
|||
| render(element: IUISchemaElement, subSchema: SchemaElement, schemaPath: string, services: JSONForms.Services) { | |||
| var control = JSONForms.RenderDescriptionFactory.createControlDescription(schemaPath, services, element.label); | |||
| var control = JSONForms.RenderDescriptionFactory.createControlDescription(schemaPath, services, element.label, element.rule); | |||
There was a problem hiding this comment.
We should think about passing the element directly to the createControlDesription method, but we can solve this with via another issue, so you don't need to take action on this.
|
This looks great, I only have minor nitpicks. Can you address them, so I can merge this? |
edgarmueller
added a commit
that referenced
this pull request
Nov 11, 2015
Added support for show/hide rules
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first implementation of a possible rule support as requested in #71 .
Disable and enable rules are not supported yet.