Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue #15: Configure and implement filter for table #140

Merged
merged 6 commits into from
Nov 25, 2015

Conversation

edgarmueller
Copy link
Contributor

No description provided.

@edgarmueller
Copy link
Contributor Author

Fixes filtering by directly wiring through ui-grid options to ui-grid.

  • if useExternalFiltering is enabled, the DataProvider's filter method will be called
  • if enableFiltering is set, default internal filtering is done

Both options can be set to false to completly disable filtering.

defaultGridOptions.totalItems = dataProvider.getTotalItems();
} else {
let externalPaginationEnabled = ArrayRenderer.isExternalPagingAvailable(dataProvider, existingOptions);
let externalFilteringEnabled = ArrayRenderer.isExternalFilterAvailable(dataProvider, existingOptions);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can the existingOptions parameter be undefined/null here? if so both static method should handle this correctly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shouldn't be because defaultGridOptions is called with element.options || {}

@eneufeld
Copy link
Member

Thank you, looks good, just some questions

@edgarmueller
Copy link
Contributor Author

Thanks for the review, I will push an update later today.

@eneufeld
Copy link
Member

Thanks for the clarification

@eneufeld
Copy link
Member

Looks good, thanks for the great work.
Just add a test for the table so the coverage check doesn't fail.

edgarmueller added a commit that referenced this pull request Nov 25, 2015
Fix for issue #15: Configure and implement filter for table
@edgarmueller edgarmueller merged commit d1d0c11 into eclipsesource:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants