-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for issue #15: Configure and implement filter for table #140
Conversation
Fixes filtering by directly wiring through ui-grid options to ui-grid.
Both options can be set to |
defaultGridOptions.totalItems = dataProvider.getTotalItems(); | ||
} else { | ||
let externalPaginationEnabled = ArrayRenderer.isExternalPagingAvailable(dataProvider, existingOptions); | ||
let externalFilteringEnabled = ArrayRenderer.isExternalFilterAvailable(dataProvider, existingOptions); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can the existingOptions parameter be undefined/null here? if so both static method should handle this correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It shouldn't be because defaultGridOptions
is called with element.options || {}
Thank you, looks good, just some questions |
Thanks for the review, I will push an update later today. |
Thanks for the clarification |
Looks good, thanks for the great work. |
Fix for issue #15: Configure and implement filter for table
No description provided.