Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix time field not being disabled #1502

Merged
merged 2 commits into from Oct 8, 2019
Merged

Fix time field not being disabled #1502

merged 2 commits into from Oct 8, 2019

Conversation

TheZoker
Copy link
Collaborator

@TheZoker TheZoker commented Sep 20, 2019 •
edited

Fixes #1500

@sdirix

@coveralls
Copy link

coveralls commented Sep 20, 2019 •
edited

Coverage Status

Coverage increased (+0.4%) to 84.23% when pulling 5723922 on TheZoker:fix-time-disabled into c9edb1f on eclipsesource:master.

@sdirix
Copy link
Member

sdirix commented Sep 20, 2019

Please add a testcase :)

@sdirix sdirix self-requested a review October 8, 2019 09:14
sdirix
sdirix approved these changes Oct 8, 2019
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! Thanks!

@sdirix sdirix merged commit 3f5d8bd into eclipsesource:master Oct 8, 2019
@TheZoker TheZoker deleted the fix-time-disabled branch October 8, 2019 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disabling a control with format time has no effect
3 participants
@TheZoker @coveralls @sdirix