Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework JsonFormsStateProvider #1583

Merged
merged 2 commits into from May 13, 2020
Merged

Rework JsonFormsStateProvider #1583

merged 2 commits into from May 13, 2020

Conversation

AlexandraBuzila
Copy link
Member

@AlexandraBuzila AlexandraBuzila commented May 12, 2020 •
edited by sdirix

Fixes #1574 & Fixes #1539

@coveralls
Copy link

coveralls commented May 12, 2020 •
edited

Coverage Status

Coverage decreased (-0.03%) to 89.165% when pulling e77463f on AlexandraBuzila:fix/config-standalone into a9da623 on eclipsesource:master.

@sdirix sdirix changed the title Offer config customization in Standalone Renderer #1574 Offer config customization in Standalone Renderer May 13, 2020
sdirix
sdirix requested changes May 13, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should merge the config with the default one. I'll take care of that.

@sdirix
Rework JsonFormsStateProvider
e77463f 
 * Initialize with Actions.init instead of delaying it
 * Reuse the config reducer

Initializing with Actions.init avoids invalid core states as we assume
that Actions.init was called from the very beginning. Usually these
invalid core states don't have consequences however sometimes the app
crashed (see eclipsesource#1539).

Reusing the config reducer makes sure that the config always contains at
least the default values.
@sdirix sdirix changed the title Offer config customization in Standalone Renderer Rework JsonFormsStateProvider May 13, 2020
sdirix
sdirix approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in react-seed and can confirm that config works and the crash is also fixed.

@sdirix sdirix merged commit 1200706 into eclipsesource:master May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Offer config customization in Standalone Renderer Standalone: Cannot read property 'compile' of undefined
3 participants
@AlexandraBuzila @coveralls @sdirix