Refactored array control #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,7 @@ | |||
| "angular-ui-grid": "3.0.7", | |||
| "angular-ui-validate": "1.2.2", | |||
| "bootstrap": "3.3.6", | |||
| "lodash": "4.5.0", | |||
There was a problem hiding this comment.
does this help so much? and if so use a dynamic version instead of the static version
There was a problem hiding this comment.
I'd argue yes, simply because it provides functionality we should not try to re-implement ourselves. Also, I think this will allow us to clean up some of the existing code. But good point on the version though.
|
Thank you, this looks good. I only have some small questions/issues. |
This was referenced Feb 25, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #177, #176