Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Draft) angular/angular-material 13 #1994

Closed
wants to merge 2 commits into from
Closed

(Draft) angular/angular-material 13 #1994

wants to merge 2 commits into from

Conversation

JBBianchi
Copy link
Contributor

An attempt to migrate angular related packaged to v13 for full Ivy support.

Changes applied:

  • (angular/angular-material) Migrated to Angular 13
  • (all) Migrated to TypeScript 4.6.4
  • (material) Fixed implicit any type

Notes:
@jsonforms/material-renderers tests are failing.

Closes #1993

- (angular/angular-material) Migrated to Angular 13
- (all) Migrated to TypeScript 4.6.4
- (material) Fixed implicit `any` type

#eclipsesource/jsonforms/1993
@CLAassistant
Copy link

CLAassistant commented Aug 2, 2022

CLA assistant check
All committers have signed the CLA.

@sdirix
Copy link
Member

sdirix commented Aug 8, 2022

Thank you for the PR! We'll take a look soonish!

@JBBianchi
Copy link
Contributor Author

thanks @sdirix , let me know if I can help.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test the built Angular components in practice? At least the Angular example app (npm run dev in packages/angular-material) no longer works.

For this to be merged:

  • All example apps within this repository must work
  • The broken test cases must be fixed
  • The Angular seed must be able to consume the new modules and continue to work

packages/angular-test/package-lock.json Outdated Show resolved Hide resolved
packages/core/package-lock.json Outdated Show resolved Hide resolved
packages/examples/package-lock.json Outdated Show resolved Hide resolved
packages/material/package-lock.json Outdated Show resolved Hide resolved
packages/react/package-lock.json Outdated Show resolved Hide resolved
packages/vue2/vue2-vanilla/package-lock.json Outdated Show resolved Hide resolved
packages/vue2/vue2/package-lock.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
packages/angular/package.json Show resolved Hide resolved
packages/angular-material/package.json Show resolved Hide resolved
- Adjust typescript version
- Adjust peer dependencies
- Remove no longer needed core-js dependencies
@sdirix
Copy link
Member

sdirix commented Aug 12, 2022

I fixed all minor comments I discovered during my review, however the major points still need to be addressed:

  • All example apps within this repository must work
  • The broken test cases must be fixed
  • The Angular seed must be able to consume the new modules and continue to work

@JBBianchi
Copy link
Contributor Author

As the tests for @jsonforms/material-renderers were failing, I didn't go further yet and run examples/seeds. I'll have a look at the angular/angular-material ones.

@JBBianchi
Copy link
Contributor Author

JBBianchi commented Sep 14, 2022

I tried to progress on bit on that task recently but I'm running into issues with typedoc (need to remove the theme/ignoreCompilerErrors for instance) and vue conflicting versions.

Basically update Angular => update Typescript ==> update typedoc/ts-jest/vue-jest and so on.

@JBBianchi JBBianchi closed this Nov 7, 2022
This was referenced Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Angular Ivy distribution
3 participants