-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Draft) angular/angular-material 13 #1994
Conversation
- (angular/angular-material) Migrated to Angular 13 - (all) Migrated to TypeScript 4.6.4 - (material) Fixed implicit `any` type #eclipsesource/jsonforms/1993
Thank you for the PR! We'll take a look soonish! |
thanks @sdirix , let me know if I can help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test the built Angular components in practice? At least the Angular example app (npm run dev
in packages/angular-material
) no longer works.
For this to be merged:
- All example apps within this repository must work
- The broken test cases must be fixed
- The Angular seed must be able to consume the new modules and continue to work
- Adjust typescript version - Adjust peer dependencies - Remove no longer needed core-js dependencies
I fixed all minor comments I discovered during my review, however the major points still need to be addressed:
|
As the tests for |
I tried to progress on bit on that task recently but I'm running into issues with typedoc (need to remove the theme/ignoreCompilerErrors for instance) and vue conflicting versions. Basically update Angular => update Typescript ==> update typedoc/ts-jest/vue-jest and so on. |
An attempt to migrate angular related packaged to v13 for full Ivy support.
Changes applied:
any
typeNotes:
@jsonforms/material-renderers
tests are failing.Closes #1993