Add Sort buttons to Angular Material ArrayLayoutRenderer and TableRenderer #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Hi @fredjohnd , thank you very much for your contribution :) The changes generally look good to me. Would it be possible to add an example for an array with detail? You could either add it to your new example or add another one.
The reason to have this in an example is that it's currently not possible to test the sort buttons of an array with detail in the examples. For a schema and uischema, you can have a look at packages/examples/src/examples/arrays-with-detail.ts
lucas-koehler
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Sort functionality to Angular Material package, as long as
options.showSortButtonsis True.This is my first PR for this project, so please let me know if something is not quite right.
Test coverage added as well as example in packages/examples.