Add tooltip for remove, up and down button on MaterialArrayLayout and MaterialArrayControl #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
lucas-koehler
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Hi @Maxouwell ,
thank you for this contribution ❤️
The code looks already pretty good to me and works as expected in the example app :)
I only have a few minor remarks inline. Please have a look.
packages/material-renderers/test/renderers/MaterialArrayLayout.test.tsx
Outdated
Show resolved
Hide resolved
packages/material-renderers/test/renderers/MaterialArrayLayout.test.tsx
Outdated
Show resolved
Hide resolved
packages/material-renderers/test/renderers/MaterialArrayLayout.test.tsx
Outdated
Show resolved
Hide resolved
… MaterialArrayControl
Maxouwell
force-pushed
the
fix/mui-array-delete-button-tooltip
branch
from
74d46a0
to
632ef31
Compare
|
Sorry, didn't see you commented on the PR ! I'm doing your comments |
Maxouwell
changed the title
|
(should I be the one resolving the conversations ?) |
lucas-koehler
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Hi @Maxouwell , thanks for the updates and also updating the table control :)
You can resolve comments that you deem fixed in the future but I did it for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #2284