Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 18 Update #2340

Merged
merged 1 commit into from
May 27, 2024
Merged

Angular 18 Update #2340

merged 1 commit into from
May 27, 2024

Conversation

lucas-koehler
Copy link
Contributor

Based on PR #2337 extended by using the Angular 18 release and regenerated pnpm lock file by me.

Copy link

netlify bot commented May 23, 2024

Deploy Preview for jsonforms-examples ready!

Name Link
🔨 Latest commit 70e26f8
🔍 Latest deploy log https://app.netlify.com/sites/jsonforms-examples/deploys/6654825c19723f0008125b21
😎 Deploy Preview https://deploy-preview-2340--jsonforms-examples.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lucas-koehler
Copy link
Contributor Author

@laurentgrangier Please confirm whether JsonForms works for you with Angular 18 in this state. If yes, we'll merge this and do a release soon.

@coveralls
Copy link

coveralls commented May 23, 2024

Coverage Status

coverage: 83.322% (-0.03%) from 83.347%
when pulling 70e26f8 on codeblock/feature/upgrade-angular-18
into 5c5a470 on master.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add the information about the angular upgrade in the migration document

@lucas-koehler
Copy link
Contributor Author

@sdirix Good point! I added a Json Forms 3.3 section mentioning this to MIGRATION.md

@lucas-koehler lucas-koehler linked an issue May 23, 2024 that may be closed by this pull request
@laurentgrangier
Copy link
Contributor

@lucas-koehler Thank you for the new PR and the upgrade to Angular 18 final version. I check JsonForms with Angular 18 and give you feedback quickly (should be this week).

@laurentgrangier
Copy link
Contributor

@lucas-koehler I tested JSONForms built on this branch with our software using Angular 17 and also using Angular 18 and had no problem with JSONForms. We only use jsonforms/core and jsonforms/angular. No other packages of jsonforms.

@sdirix sdirix force-pushed the codeblock/feature/upgrade-angular-18 branch from 9563337 to 0bfd686 Compare May 27, 2024 12:53
Updates code base to Angular 18. This removes support for Angular 16.

Also includes the following changes:

- removal of the angular test package
- Typescript update
- migration guide entry

Co-authored-by: Lucas Köhler <lkoehler@eclipsesource.com>
@sdirix sdirix force-pushed the codeblock/feature/upgrade-angular-18 branch from 0bfd686 to 70e26f8 Compare May 27, 2024 12:53
@sdirix sdirix merged commit 2f7e64c into master May 27, 2024
11 checks passed
@sdirix sdirix deleted the codeblock/feature/upgrade-angular-18 branch May 27, 2024 13:18
@sdirix
Copy link
Member

sdirix commented May 27, 2024

I also tested with React 18 in the Angular Seed application. That works 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Angular 18 support
4 participants