-
Notifications
You must be signed in to change notification settings - Fork 352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial contribution for vue-vuetify renderer set #2341
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for jsonforms-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@sdirix can you review and check why we have out of memory failure on the build machine ? Perhaps we need a build machine with more memory ? |
…n the additioanl properteis renderer
@sdirix the build is fixed - I had to change
to
in the vuetiy package - if you want you can remove that from there and place it in the ci.yaml the same way how we set that for test to be set on build as well but that is up to you. |
Thanks! I plan to take a look at this PR next week. I was wondering whether we should preserve the history of the other repository, i.e. instead of copying all files over to here, we can add the vue3-branch into this repository as an orphan-branch and then do a merge commit with the content of the first commit here. This would keep the history. Suggestion: Once this PR here is in a good state and reviewed, I can do as suggested above with your contribution here as a commit on top. Note that we currently lose the new features we recently introduced in the Can you re-integrate those changes? |
I can review and apply those changes - keep in mind that this PR will have almost the same thing as the PR for fixing the vue3 without the recent changes (few weeks ago) that were merged into that repo, and also this PR different from the PR against the older vue 3 vuetify 3 repository since I had to integrate that with the jsonforms main repo and most of the changes are in the example so both example apps are different between this PR and the other one. If you want to keep the history please create the proper PR with the history from the other repo and the either I or you can override that on top and have the history there. |
@sdirix the requested PRs are applied to this PR |
…pt types for compositions, organize imports
@kchobantonov Thank you very much! |
…m another bound control to the same data
…data is kept in sync
…jsonform to render the property name control
Co-authored-by: Manuel Meister <news.manuelsworld@gmail.com>
I'm looking at the PR. I plan to contribute the migration and finish the review next week. |
@sdirix please review the initial contribution that have the changes that fixes the vue3 integration. Few things to note:
ajv-i18n
since the Vite do not like the require when expecting to use import