Clean-up of PathUtil #241
Merged
Clean-up of PathUtil #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eneufeld This is a refactoring I did in my spare time to explore lodash. No issue or whatsoever tracks this. |
| * @returns {any} the last fragment in a beautified manner | ||
| */ | ||
| static beautifiedLastFragment(schemaPath: string): string { | ||
| return _.flow(PathUtil.lastFragment, _.upperFirst, PathUtil.beautify)(schemaPath); |
There was a problem hiding this comment.
the _.uperFirst call is not necessary as the beautify method will upper case the string
|
Thank you, the code is much better readable. I added two small comments, but they should/could be fixed separately as they are improvements |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactoring of PathUtil + JSDoc, also fixed some minor warnings.
Usage of start case when beautifying labels.
Fixed name of inits function, which actually should be named init (as e.g. here).