Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generation of d.ts #263

Merged
merged 2 commits into from
May 9, 2016
Merged

Added generation of d.ts #263

merged 2 commits into from
May 9, 2016

Conversation

eneufeld
Copy link
Member

@eneufeld eneufeld commented May 9, 2016

Updated tsconfig.json to generate d.ts files in the dist/js folder.

@edgarmueller please review

@eneufeld eneufeld added this to the 0.0.30 milestone May 9, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 91.538% when pulling 655bdc8 on eneufeld:feat_dts into cde05b9 on eclipsesource:master.

edgarmueller
edgarmueller reviewed May 9, 2016
View reviewed changes
tsconfig.json
"module": "commonjs",
"experimentalDecorators": true,
"outDir": "dist/src"
"outDir": ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this have to be empty or can we simply get rid of the outDir property?

@edgarmueller
Copy link
Contributor

@eneufeld Looks good, just a question regarding the outDir property.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 91.624% when pulling e4a19cc on eneufeld:feat_dts into cde05b9 on eclipsesource:master.

@edgarmueller edgarmueller merged commit 752e2f8 into eclipsesource:master May 9, 2016
@edgarmueller
Copy link
Contributor

Thank you!

@eneufeld eneufeld deleted the feat_dts branch December 7, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@edgarmueller edgarmueller

Labels
None yet
Projects
None yet
Milestone
0.0.30
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eneufeld @coveralls @edgarmueller