Replace 'replace' for A2 compatiblity #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… introduce additional div nodes where CSS classes can be set. Also added missing CSS style for categorization.
| </fieldset> | ||
| </uib-tab> | ||
| </uib-tabset> | ||
| <div class="jsf-categorization"> |
There was a problem hiding this comment.
why not add the jsf-categorization class to the existing div?
i think, that the new div might destroy the grid that is created by bootstrap.
There was a problem hiding this comment.
Placing the class attribute onto the existing elements didn't work with the vertical/horizontal layout, that's why I also introduced the additional element here as well, but I didn't actually give it a try. Will do.
|
Looks good, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON Forms can't not be used with A2 migration mode, since we use
replacein our code base.I'm not very happy with this fix, since it introduces additional DOM elements, but I couldn't think of something else in order to keep the restriction that CSS layout styles should only be applied in case the respective layouts are visible.
Furthermore the PR also adds missing style capabilities for categorizations and groups.
This commit also contains two minor fixes that bugged me as well: that the person example is still called 'local' and that we did not yet include any usage info about JSON Forms in the README (although, of course, it's still WIP). If necessary I can also push them as single commits, I was just too lazy to do so :)