Extracted Bootstrap

[eneufeld]

• Bootstrap templates are now optional. To use you have to run build-bootstrap.
• extracted css to single files, currently must be copied by hand to dist
• fixed bugs with treemaster detail

@edgarmueller sorry this is a bit of a mess

[coveralls]

Coverage decreased (-4.0%) to 87.626% when pulling 18cfee4 on eneufeld:feat_bootstrap into 7876ce7 on eclipsesource:master.

[edgarmueller]

Instead of copying the whole app.js file we also could just include this line and make sure it is loaded after app.js in index-bootstrap.html

[edgarmueller]

This already looks great and I have commented on some minor issues, but I also have some questions, since I'm am not entirely sure whether everything is supposed to work already:

• Does the horizontal layout work (without bootstrap, I saw the flex is being used at some point)?
• Does master/detail work (without bootstrap), clicking user/enemies in the person example has no effect?
• Would it make sense to extract the whole bootstrap part and release it as a standalone NPM package that can be used with the 'core', i.e. it would overwrite existing renderers when it has been included.

[eneufeld]

Hi thank you for the review.

• horizontal layout should work
• master/detail should work -> you have to press the chevron
• ideally I would like to have a jsonforms-bootstrap.js which would contain only the bootstrap renderers and bootstrap dependencies and which could be loaded after the jsonforms.js, but I don't know how to configure the build accordingly.

[edgarmueller]

Regarding the last point: Yes, that's also what I'd like to have. About the build: nevermind, we leave that up to @sdirix 😁

[edgarmueller]

Ah, I forgot to copy a CSS file, of course. You should be able to use the this plugin and update the webpack files accordingly.

// at the top 
var CopyWebpackPlugin = require('copy-webpack-plugin');

and in the plugins section add this entry:

new CopyWebpackPlugin([
    { from: 'src/jsonforms.css' }
]),

Likewise for the bootstrap webpack.

[coveralls]

Coverage decreased (-4.0007%) to 87.616% when pulling 7ba13cb on eneufeld:feat_bootstrap into e67107e on eclipsesource:master.