Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extended the uigenerator and adapted arraycontrol accordingly #283

Merged
merged 2 commits into from
Jul 5, 2016
Merged

extended the uigenerator and adapted arraycontrol accordingly #283

merged 2 commits into from
Jul 5, 2016

Conversation

eneufeld
Copy link
Member

Fixes #235

@edgarmueller please review

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 88.63% when pulling 2e92bbf on eneufeld:feat_group into 33beaf3 on eclipsesource:master.

edgarmueller
edgarmueller reviewed Jul 5, 2016
View reviewed changes
src/components/generators/jsonforms-uischemagenerator.ts
@@ -61,44 +62,48 @@ export class UISchemaGenerator implements IUISchemaGenerator {
* @param uiSchema The ui schema to wrap in a vertical layout.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc is out-of-date.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 88.798% when pulling c208e19 on eneufeld:feat_group into 43a1ffa on eclipsesource:master.

@edgarmueller edgarmueller merged commit 47bcf56 into eclipsesource:master Jul 5, 2016
@edgarmueller
Copy link
Contributor

Thanks!

@eneufeld eneufeld deleted the feat_group branch December 7, 2017 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eneufeld @coveralls @edgarmueller