-
Notifications
You must be signed in to change notification settings - Fork 360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure typings for external use #289
Conversation
@eneufeld I tested this by compiling locally and consuming the result in another NPM project. |
export class JsonFormsDirective implements ng.IDirective { | ||
static $inject = ['$templateCache']; | ||
constructor($templateCache: ng.ITemplateCacheService) { | ||
$templateCache.put('form.html', formTemplate); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not do this in a run block, just like in all other cases?
The jsonforms.ts is now a mixup of two schema definitions (ui-schema and json-schema) and our exports, is this a good way to do it? |
Looks good, |
I probably do..will update 😅 |
looks good, thank you |
Export typings and put generated source into root folder (also update .gitignore). This enables API consumers to do imports a-la
import { ... } from "jsonforms"
.I'm not sure whether all required types/values are exported but I'd add those opportunistically.