Configure typings for external use #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eneufeld I tested this by compiling locally and consuming the result in another NPM project. |
| export class JsonFormsDirective implements ng.IDirective { | ||
| static $inject = ['$templateCache']; | ||
| constructor($templateCache: ng.ITemplateCacheService) { | ||
| $templateCache.put('form.html', formTemplate); |
There was a problem hiding this comment.
why not do this in a run block, just like in all other cases?
|
The jsonforms.ts is now a mixup of two schema definitions (ui-schema and json-schema) and our exports, is this a good way to do it? |
|
Looks good, |
|
I probably do..will update 😅 |
|
looks good, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export typings and put generated source into root folder (also update .gitignore). This enables API consumers to do imports a-la
import { ... } from "jsonforms".I'm not sure whether all required types/values are exported but I'd add those opportunistically.