♻️ Decouple layout from PDF lib types #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfstx
force-pushed
the
decouple-layout
branch
3 times, most recently
from
fafbe45
to
0e7af3b
Compare
The layout phase relied on the `pdf-lib` types `PDFFont` and `PDFImage`. These types can only be created by embedding a font or an image into the PDF. In preparation of loading font and image resources on demand, this commit decouples the layout process from these `pdf-lib` types and uses only `Font` and `Image` during layout. Before layout, fonts are now only *loaded*, i.e. the `fontkit` font is being created. To calculate text sizes, the layout now relies only on `fontkit` instead of a `PDFFont` instance. The fonts are embedded into the PDF only in the render phase. Likewise, images are loaded before layout and embedded into the PDF in the render phase. They need to be loaded in advance to get their size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The layout phase relied on the
pdf-libtypesPDFFontandPDFImage. In preparation of loading font and image resources on demand, this commit decouples the layout process from these PDF lib types and uses onlyFontandImageduring layout.Fonts are now only loaded, i.e. the fontkit font is being created before layout, since we need fontkit to calculate sizes. In the render phase, the fonts are embedded into the PDF. Likewise, images are loaded before layout to get their size, and embedded into the PDF in the render phase. During render, the PDF ref is attached to the
FontandImageinstances.