Updated syntax to ES6 #1166
Closed
Updated syntax to ES6 #1166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralfstx
requested changes
Mar 3, 2017
There was a problem hiding this comment.
Thanks for the change, Cam! It looks good, but I have some minor comments:
- let vs const: It's certainly a good practice not to reassign variables. We decided against replacing all
vars withconstas this would be in contrast to the common practice and look unfamiliar. Let's useletfor "normal" variables andconstfor imports and constant values that are declared at the top of the file, e.g.
const FUNNY_REGEX = /^\s*(#.*)$/;- We're currently releasing beta-2 and will merge your change after that, please use
2.0.0-beta2as tabris dependency. We'll later batch-replace all dependencies to the next version. - Commit messages should use the imperative mood in the subject line. They should also indicate which part of the codebase is changed. Suggestion: "Update hello example to ES6".
Please see my other comments in your commit.
| centerX: 0, top: 100, | ||
| text: 'Show message' | ||
| }).appendTo(tabris.ui.contentView); | ||
|
|
||
| var textView = new tabris.TextView({ | ||
| const textView = new TextView({ |
| var button = new tabris.Button({ | ||
| const {Button, TextView} = require('tabris'); | ||
|
|
||
| const button = new Button({ | ||
| centerX: 0, top: 100, | ||
| text: 'Show message' | ||
| }).appendTo(tabris.ui.contentView); |
There was a problem hiding this comment.
Avoid the global object tabris. Import ui and replace with appendTo(ui.contentView).
| @@ -3,7 +3,10 @@ | |||
| "description": "Tabris.js - Hello, World!", | |||
| "category": "Small Apps", | |||
| "main": "hello.js", | |||
| "scripts": { | |||
| "start": "http-server -c-1 -d false" | |||
There was a problem hiding this comment.
For 2.0, we recommend the CLI over starting a plain HTTP server: tabris serve. This should make the npm script redundant.
| "dependencies": { | ||
| "tabris": "2.0.0-beta2" | ||
| "tabris": "^2.0.0-beta1" |
There was a problem hiding this comment.
Please replace with 2.0.0-beta2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of discussions with @ralfstx, I'm beginning a series of PR's on the examples to upgrade their syntax to ES6