Create initial version of terminal command agent #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eclipsesource/osweek-2024#14 Change-Id: Ie6f531bd18a267d60959cc969f01102e2bf3e2db
Change-Id: I7d1b60047d0b3ff5fef6d5aa618ada0da96acc99
cdamus
approved these changes
Jul 30, 2024
|
|
||
| const lms = await this.languageModelRegistry.selectLanguageModels(this.languageModelRequirements[0]); | ||
| if (lms.length === 0) { | ||
| console.error('No language model available for the AI Terminal Agent.'); |
There was a problem hiding this comment.
Should we prefer the logger or the message service?
|
|
||
| const lm = lms[0]; | ||
|
|
||
| const systemPrompt = this.promptService.getPrompt('ai-terminal:system-prompt', input)!; |
There was a problem hiding this comment.
How do we know that we'll get a defined result from the prompt service?
Change-Id: I8544ed38a02e37c5d9de940ed808c5da7d0aa03e
|
Thank you very much for your review! I've addressed your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Adds an initial simple version of a terminal command agent.
Screencast.from.07-30-2024.11.39.03.AM.webm
https://github.com/eclipsesource/osweek-2024/issues/14
How to test
Open a terminal and right-click to select "Start AI Chat" or hit Ctrl-i.
Follow-ups