Improve link handling in markdown links #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Extend EditorManager to have more flexible selection resolution - Allow adopters to register selection resolvers -- Provide selection resolver for GitHub location syntax -- Provide selection resolver for TypeDoc symbol navigation -- Provide selection provider for fragment textual search - Fix minor issue in editor-manager where URI is not passed properly Fixes eclipsesource/osweek-2024#18
martin-fleck-at
force-pushed
the
feat/18-markdown-links
branch
from
cd464f4
to
452bb05
Compare
Comment on lines
153
to
155
| const input = uri.toString(); | ||
| const hashIndex = input.indexOf('#'); | ||
| return hashIndex === -1 ? undefined : input.substring(hashIndex + 1); |
There was a problem hiding this comment.
Maybe I'm missing something but couldn't you just use uri.fragment to get the fragment?
There was a problem hiding this comment.
Good catch! I was starting with string manipulation and only later moved it into the editor manager where we already have the URI, thank you!
Comment on lines
105
to
107
| const input = uri.toString(); | ||
| const hashIndex = input.indexOf('#'); | ||
| return hashIndex === -1 ? undefined : input.substring(hashIndex + 1).split('.'); |
There was a problem hiding this comment.
Maybe I'm missing something but couldn't you just use uri.fragment to get the fragment?
There was a problem hiding this comment.
Same as above, good catch, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
-- Provide selection resolver for GitHub location syntax
-- Provide selection resolver for TypeDoc symbol navigation
-- Provide selection provider for fragment textual search
Fixes https://github.com/eclipsesource/osweek-2024/issues/18
How to test
file://<path>#<location>where location isL<start-line>C<start-column>-L<end-line>C<end-column>(end position is optional and all columns are optional as well)file://<path>#<symbol-path>where symbol path can be just the symbol name (e.g., a function name in TypeScript) or a nested path in the form ofparent.child(e.g., a function nested in a namespace). Ensure symbols are actually provided for your document by checking the Outline or triggering the command 'Go to Symbol...` (not Go to Symbol in Workspace...).file://<path>#<text>Follow-ups
Review checklist
Reminder for reviewers