Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointCloud Fortran interface #17

Conversation

benjaminmenetrier
Copy link
Contributor

Hello @wdeconinck, I hope that you are well.

This PR has been merged in the develop-jcsda branch already (#12). Since it does not impact any existing feature of ATLAS, we would like to have it merged into the develop branch of ECMWF.

It would be nice if this PR could be merged this week, since we would like to merge a branch of SABER next week that uses this feature.

@codecov-io
Copy link

Codecov Report

Merging #17 into develop will increase coverage by 0.05%.
The diff coverage is 7.40%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #17      +/-   ##
===========================================
+ Coverage    71.50%   71.56%   +0.05%     
===========================================
  Files          506      505       -1     
  Lines        32272    32240      -32     
===========================================
- Hits         23077    23071       -6     
+ Misses        9195     9169      -26     
Impacted Files Coverage Δ
src/atlas/functionspace/PointCloud.cc 66.35% <0.00%> (-9.99%) ⬇️
src/atlas/functionspace/PointCloud.h 91.17% <ø> (ø)
.../atlas/functionspace/detail/PointCloudInterface.cc 11.11% <11.11%> (ø)
...atlas/meshgenerator/detail/MeshGeneratorFactory.cc 84.61% <100.00%> (+4.61%) ⬆️
src/atlas/mesh/actions/BuildNoConnectivityMesh.cc
...eshgenerator/detail/NoConnectivityMeshGenerator.cc
src/atlas/output/detail/GmshIO.cc 70.59% <0.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fba366f...a4a1797. Read the comment docs.

@wdeconinck
Copy link
Member

Hi Benjamin,
I have spent the past week merging in the develop-jcsda branch into develop, which also contains your changes, although I have squashed and moved around some commits.
It also should contain the Bugfix for the structuredcolumns that you reported.
It is just pushed now.
If the develop branch in current state works for you now, let me know, and I can close this PR.

@benjaminmenetrier
Copy link
Contributor Author

Hi @wdeconinck, thank you very much for this merge. I have tested our branches that require the PointCloud fortran interfaces with your develop branch and all the tests are successful.

We will mirror your develop branch into our fork next week. I'm glad both repos will be in sync again!
I mention @ytremolet to let him know.

@benjaminmenetrier benjaminmenetrier deleted the feature/pointcloud_fortran_interface branch April 20, 2020 08:14
@wdeconinck wdeconinck added the Status: Merged PR has been merged in alternative way label Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Merged PR has been merged in alternative way
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants