Disable recursing in tests directory if tests are disabled #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CMakeLists.txt in the tests directory is trying to enable assertions even if the tests are disabled. This is done by trying to set properties of the test target, but since the tests are disabled, the test target is not created so the cmake generation step fails.
pmaciel
approved these changes
Mar 23, 2023
|
Unfortunately, this is not fixing the issue at all -- it is disabling mir's testing altogether, which is a problem. I'm testing/releasing a hotfix/1.16.5 to ensure this is correctly handled |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CMakeLists.txt in the tests directory is trying to enable assertions even if the tests are disabled. This is done by trying to set properties of the test target, but since the tests are disabled, the test target is not created so the cmake generation step fails.