增加Pair类型 #237
Merged
增加Pair类型 #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #237 +/- ##
==========================================
+ Coverage 95.85% 95.93% +0.08%
==========================================
Files 65 66 +1
Lines 3328 3394 +66
==========================================
+ Hits 3190 3256 +66
Misses 106 106
Partials 32 32 ☔ View full report in Codecov by Sentry. |
flycash
reviewed
Jan 4, 2024
flycash
previously approved these changes
Jan 7, 2024
|
手贱点了update branch :( |
|
测试失败了，看看是啥原因。本地运行一下试试。 |
已修复，随机出现的bug，起因是map遍历的时候可能不是按照顺序的 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
主要参考了 PR #164 和 issue #161 中的评论。
如果对Pair的实现没有异议的话，后续可以根据当前实现继续增加对Triple的支持。