Skip to content
This repository has been archived by the owner on Jan 20, 2020. It is now read-only.

Added tests and fixes #6

Merged
merged 17 commits into from
Oct 17, 2013
Merged

Added tests and fixes #6

merged 17 commits into from
Oct 17, 2013

Conversation

altaurog
Copy link

This poor project seems to be languishing. We would like to start using it in production so I have given it a bit of attention:

  • I reorganized the code
  • I added tests for the current ArrayField classes
  • I fixed the DateFieldArray, as well as lookups for the other fields
  • I updated the documentation
  • I added an AUTHORS.txt file

I also took the liberty of reformatting the docs and assigning a new version number.

I have no problem pulling from my fork on github into production environments, but it would be great to have these changes integrated back upstream and released on pypi.

@wiswaud
Copy link
Contributor

wiswaud commented Oct 17, 2013

wow - awesome work thank you!
just one thing before i pull - i see that you now let dbarray init itself on other db connections than psycopg2, but it's unclear to me from a cursory look where it's serializing / deserializing. IOW, looks like it'll just bomb later, but i'm likely just missing something?

@altaurog
Copy link
Author

I'm not sure to what you are referring. There is a function require_postgres() which is called by db_type() that raises an exception if the db connection is not psycopg2 or postgis. I didn't touch that part. I also didn't test on other db connections to see if it fails.

wiswaud added a commit that referenced this pull request Oct 17, 2013
@wiswaud wiswaud merged commit 5fbfd1f into ecometrica:master Oct 17, 2013
@wiswaud
Copy link
Contributor

wiswaud commented Oct 21, 2013

redhog's email address turned out to be undeliverable, so i've filed https://sourceforge.net/p/pypi/support-requests/306/ to regain ownership. Will upload new version when i can, but in the meantime, assuming you're using virtualenv, you can always include it by git url?

@altaurog
Copy link
Author

Yes of course; we already are.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants