Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

其實這邊的repo是不是沒有人理了? Is this repo still a live one? #68

Open
bbqaaq opened this issue May 10, 2018 · 9 comments

Comments

@bbqaaq
Copy link

bbqaaq commented May 10, 2018

空白變感嘆的問題其實兩年前已經有人提出了, 但兩年都沒好像沒有人去解決


#31

#40
#39
#43

全部都是同一個問題
我查過一下, 其實是出在fonteditor-core 那邊的問題
但那邊的新版本沒有理這個問題

請問repo的負責人們可以回應下嗎?

@bbqaaq
Copy link
Author

bbqaaq commented May 10, 2018

And maybe I could recap it in English and let others know what Im saying...

This repo is having a bug that converting space character into a wrong character of "!",
and it persists for two years already.

From
#31
to
#40
#39
#43

All these issues are mentioning the same problem, seems the contributors aren't reacting.
I have check the root cause of this issue, and seems its coming from 'fonteditor-core'.
' fonteditor-core' did have released some new versions but not tackling this problem.

Could any of this repo's owner response to this?

@bbqaaq bbqaaq changed the title 其實這邊的repo是不是沒有人理了? 其實這邊的repo是不是沒有人理了? Is this repo still a live one? May 10, 2018
@bbqaaq
Copy link
Author

bbqaaq commented May 10, 2018

I just submit a fix to fonteditor-core, which can really solve the root problem about the fix
kekee000/fonteditor-core#16

But need to wait for that repo's update
this side repo better move to use the new version later

@junmer
Copy link
Contributor

junmer commented May 10, 2018

@bbqaaq 感谢您的反馈,作者非常羞愧 (:3 」∠ )

请看一下 这个版本 是否解决了您的问题

@bbqaaq
Copy link
Author

bbqaaq commented May 11, 2018

感謝你你的回應, 但抱歉看來問題有沒被解決 (剛試了)
我昨天查了, 問題其實出在fonteditor-core那邊, 你可以看到我在邊的pull request
所以你這邊改是沒法解決的

另外, 想問一下, 為什麼要把node換做8.0以上呢?
其實我這邊是用6.x 的, 而6.x 其實是LTS version來的, 應該很多人還在用的

English:
Thanks for your reply, but the problem isn't solved yet
Yesterday I scan through the code, it turns out that the spacing problem is coming from
the fonteditor-core, not this repo, as you can see from my pull request
Changing the code on this side can't make it.

Beside, I have seen that you have migrated the node version to support 8.0+
But may I ask whats the intention? Indeed Im still using 6.x, which is still a node js LTS version
So probably many systems are still using it

@junmer
Copy link
Contributor

junmer commented May 14, 2018

  1. 可以提供一下具体的用例么?

    1. 字体文件
    2. 配置
  2. 因为支持了 woff2 ,引入了 emscripten ,需要 8.0 以上支持

@bbqaaq
Copy link
Author

bbqaaq commented May 15, 2018

  1. 其實隨手在google font 抓一個都應該有見到這問題的
    e.g. abeezee regular
    http://fonts.gstatic.com/s/abeezee/v11/esDR31xSG-6AGleN6tI.ttf

let fontmin = new Fontmin() .src("xxxx.ttf") .use(Fontmin.glyph({ text, basicText: true, trim: false, hinting: true })) fontmin.run((err, files, stream)=>{ ... })

@mebtte
Copy link

mebtte commented May 29, 2018

其实我也想问这个项目现在还维护吗?好像很久都没更新了。我想用在生产环境上,如果不维护的话我只能寻找其他替代方案了。

@bbqaaq
Copy link
Author

bbqaaq commented May 29, 2018

其實我用起來發現還有很多地方可以改進的
e.g. 沒有處理GSUB/GPOS/kern 這些font 的表格
所以如果要正式拿來用作font server的工具其實還有很多地方要改的

但你如果有看程式源, 你會發現fontmin 本身寫的東西都挺足夠的
而問題反而是來自font 引擎 fonteditor-core 那邊
所以這repo沒更新不是最大問題, 要更新的是fonteditor-core那邊

english version:
Recently I try to use fontmin as my font server's main library, and I discover that there are still a few missing features.
e.g. fontmin didn't handle the original font file's GSUB/GPOS/kern table
So if you wanna use fontmin for you production environment, it's still not a stable enough library

However, if you dig into the source code, you may find that the problems is coming
from the font engine side, i.e. fonteditor-core, but not fontmin itself
So fontmin itself not updating isn't the biggest problem, but the fonteditor-core side does.

@Wolke
Copy link

Wolke commented May 30, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants