-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/define accessor #14
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
/** | ||
* Created by exodia on 14-8-28. | ||
*/ | ||
void function (define, undefined) { | ||
|
||
define( | ||
function (require) { | ||
var MEMBERS = '__eooPrivateMembers__'; | ||
|
||
function simpleGetter(name) { | ||
var body = 'return typeof this.' + MEMBERS + ' === \'object\' ? this.' | ||
+ MEMBERS + '[\'' + name + '\'] : undefined;'; | ||
return new Function(body); | ||
} | ||
|
||
function simpleSetter(name) { | ||
var body = 'this.' + MEMBERS + ' = this.' + MEMBERS + ' || {};\n' | ||
+ 'this.' + MEMBERS + '[\'' + name + '\'] = value;' ; | ||
return new Function('value', body); | ||
} | ||
|
||
/** | ||
* 根据指定的属性名生成对应的accessor | ||
* | ||
* @param {Object | Function} obj 需要生成 accessor 的对象 | ||
* @param {string} name 需要生成 accessor 的属性名称 | ||
* @param {Object | Function} [accessor] 自定义的 getter 和 setter 配置 | ||
* @param {Function} [accessor.get] 自定义的 getter 函数, 配置了accessor,但未设置 get,则不会生成 getter | ||
* @param {Function} [accessor.set] 自定义的 setter 函数, 配置了accessor,但未设置 set,则不会生成 setter | ||
*/ | ||
return function (obj, name, accessor) { | ||
var upperName = name.charAt(0).toUpperCase() + name.slice(1); | ||
var getter = 'get' + upperName; | ||
var setter = 'set' + upperName; | ||
|
||
if (!accessor) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 感觉用用函数预编译能加快些速度呢…… There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done |
||
obj[getter] = !accessor || typeof accessor.get !== 'function' ? simpleGetter(name) : accessor.get; | ||
obj[setter] = !accessor || typeof accessor.set !== 'function' ? simpleSetter(name) : accessor.set; | ||
} | ||
else { | ||
typeof accessor.get === 'function' && (obj[getter] = accessor.get); | ||
typeof accessor.set === 'function' && (obj[setter] = accessor.set); | ||
} | ||
}; | ||
} | ||
); | ||
|
||
}(typeof define === 'function' && define.amd ? define : function (factory) { module.exports = factory(require); }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
/** | ||
* Created by exodia on 14-8-28. | ||
*/ | ||
void function (define) { | ||
define( | ||
function (require) { | ||
var oo = require('./oo'); | ||
oo.defineAccessor = require('./defineAccessor'); | ||
|
||
return oo; | ||
} | ||
); | ||
}(typeof define === 'function' && define.amd ? define : function (factory) { module.exports = factory(require); }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里我感觉不应该给
prototype
,直接给个类就行了?毕竟我们的语义是“给类添加一个访问器”There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在业务中应该是:defineAccessor(exports, name),主要考虑到defineAccessor不局限于 function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
懂了~