Feature/define accessor #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -240,6 +240,14 @@ | |||
|
|
|||
| var e2 = new EooClass2('prop1', 'prop2'); | |||
| e2.test(); | |||
|
|
|||
| Class.defineAccessor(Sub.prototype, 'testProp'); | |||
There was a problem hiding this comment.
这里我感觉不应该给prototype，直接给个类就行了？毕竟我们的语义是“给类添加一个访问器”
There was a problem hiding this comment.
在业务中应该是：defineAccessor(exports, name)，主要考虑到defineAccessor不局限于 function
added 2 commits
August 28, 2014 16:34
|
|
||
| function simpleGetter(name) { | ||
| var body = 'return typeof this.' + MEMBERS + ' === \'object\' ? this.' | ||
| + MEMBERS + '.' + name + ' : undefined;'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for ISSUE #9