Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

规范组件内命名规则 #122

Closed
Justineo opened this issue Aug 29, 2017 · 0 comments
Closed

规范组件内命名规则 #122

Justineo opened this issue Aug 29, 2017 · 0 comments

Comments

@Justineo
Copy link
Member

主要约束组件文件名、组件 name 属性和主元素的 class

规则为将 PascalCase 的文件名严格转为 kebab-case 的形式。由于之前未约定,需要修改部分已有的公有组件。(注意这是多个 breaking change,如果为特定组件 class 覆盖过样式需要随此变更更新自定义代码。)

修改清单:

CheckboxGroup
class: veui-checkboxgroup → veui-checkbox-group

RadioGroup
class: veui-radiogroup → veui-radio-group
name: veui-radiogroup → veui-radio-group

DatePicker
class: veui-datepicker → veui-date-picker
name: veui-datepicker → veui-date-picker

RegionPicker
class: veui-regionpicker → veui-region-picker
name: veui-regionpicker → veui-region-picker

PromptBox
class: veui-promptbox → veui-prompt-box
name: veui-promptbox → veui-prompt-box
Justineo added a commit that referenced this issue Aug 29, 2017
@Justineo Justineo mentioned this issue Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant