Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Hark 0.10.6 #116

Merged
merged 8 commits into from
May 21, 2020
Merged

Conversation

sbenthall
Copy link
Contributor

This PR aims to fix the DemARKs so tests pass.

Current changes adjust for the recent changes to the distribution handling in HARK.

The remaining progress is being blocked by the issue of dependencies on deprecated HARK.cstwMPC code.

See:

There is a bit of a knot of interrelated architectural and process issues here.

@project-bot project-bot bot added this to Needs Triage in Issues & PRs Apr 16, 2020
@sbenthall sbenthall changed the title [WIP] Update for Hark 0.10.6 Update for Hark 0.10.6 Apr 16, 2020
@sbenthall sbenthall requested a review from MridulS May 12, 2020 21:18
@sbenthall
Copy link
Contributor Author

Tests pass. This PR should restore the DemARKs to working order.
Could I ask for a review @MridulS ?

@MridulS
Copy link
Member

MridulS commented May 12, 2020

I think we should remove the figures directory from DemARK, only one notebook uses it.

@MridulS MridulS merged commit 3643f4f into econ-ark:master May 21, 2020
Issues & PRs automation moved this from Needs Triage to Done May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issues & PRs
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants