Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPMF for ConsIndShock #1374

Closed
sbenthall opened this issue Jan 29, 2024 · 6 comments
Closed

NPMF for ConsIndShock #1374

sbenthall opened this issue Jan 29, 2024 · 6 comments
Assignees
Milestone

Comments

@sbenthall
Copy link
Contributor

The New Python Model Format (see #1371) has been used so far for a very simple model: infinite horizon perfect foresight.

A clear next step is to implement a similar file for ConsIndShock and at it to the model library:
https://github.com/econ-ark/HARK/tree/master/HARK/models

In principle, this would enable to ConsIndShock model file to be refactored to use the generic Monte Carlo simulator, rather than its own custom simulation code.

Since there are so many variations of the ConsIndShock model supported by the current object-oriented version of the model, this task also involves putting some thought into how to efficiently encode multiple models which are slight variations of each other. This work will be roughly analogous to the way that YAML model configurations can be built off of each other.

@sbenthall sbenthall added this to the 1.0.0 milestone Jan 29, 2024
@llorracc
Copy link
Collaborator

Seb,

It is not clear to me how the proposed work here integrates with or contributes to the DSL work that Matt is heading up.

In our earlier discussions, particularly with Pablo, I thought we had reached the conclusion that a syntactic specification like that of Dolo is the only approach that has a realistic shot of convincing other people to adopt it.

I'd rather not have you work on this for Econ-ARK unless you can convince me that it is necessary to do this in order to pursue the DSL project.

@mnwhite
Copy link
Contributor

mnwhite commented Jan 30, 2024 via email

@sbenthall
Copy link
Contributor Author

Thanks @mnwhite

And yes, @llorracc , I made these issues as proposed next steps for HARK after discussing with Matt what would be productive ways forward: #1371 #1372 #1373 #1374

Essentially, what we discovered last semester is that the distance between the DSL and a Python object that it compiles to is very small. Together, these issues would establish that it's possible to use the DSL to define and work with the ConsIndShock model, which is the most important model to HARK users.

@sbenthall
Copy link
Contributor Author

This has gotten the thumbs up from @llorracc

Once we have this ready, we can make sure we can accommodate the shuffle method for simulations.
This will be a separate issue, but it is certainly in mind.

@sbenthall
Copy link
Contributor Author

Fixed in #1417

@llorracc
Copy link
Collaborator

llorracc commented May 31, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants