Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sequence Space Jacobian Notebook #1435

Closed
alanlujan91 opened this issue May 28, 2024 · 2 comments
Closed

Sequence Space Jacobian Notebook #1435

alanlujan91 opened this issue May 28, 2024 · 2 comments
Assignees

Comments

@alanlujan91
Copy link
Member

There are currently two PRs attempting to do the same thing.

One issue with #1424 is that the examples/HARK-SSJ-Example/ConsIndShockModel_HANK.py file is mostly a copy of ConsIndShockModel.py with a few things changed. The approach I took in #1416 was to remove everything related to ssj and move it to its own file, while inheriting from ConsIndShockModel without repeating chunks of code.

As far as I can tell, neither approaches work correctly yet, so I'm wondering if the authors could get together and figure out the best approach to get this through the finish line.

@wdu9 @AMonninger @kennetheva

@mnwhite
Copy link
Contributor

mnwhite commented May 28, 2024 via email

@mnwhite
Copy link
Contributor

mnwhite commented Jun 14, 2024

The notebook has now been merged into HARK and is working properly; it's currently being expanded and improved. Closing.

@mnwhite mnwhite closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants