You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
One issue with #1424 is that the examples/HARK-SSJ-Example/ConsIndShockModel_HANK.py file is mostly a copy of ConsIndShockModel.py with a few things changed. The approach I took in #1416 was to remove everything related to ssj and move it to its own file, while inheriting from ConsIndShockModel without repeating chunks of code.
As far as I can tell, neither approaches work correctly yet, so I'm wondering if the authors could get together and figure out the best approach to get this through the finish line.
I think some of the issue is due to a small change I had to put into
calc_jacobian to make it not break other things. I suspect the fix for this
code is 1-2 lines to adjust to the change.
There are currently two PRs attempting to do the same thing.
One issue with #1424 is that the
examples/HARK-SSJ-Example/ConsIndShockModel_HANK.py
file is mostly a copy ofConsIndShockModel.py
with a few things changed. The approach I took in #1416 was to remove everything related tossj
and move it to its own file, while inheriting fromConsIndShockModel
without repeating chunks of code.As far as I can tell, neither approaches work correctly yet, so I'm wondering if the authors could get together and figure out the best approach to get this through the finish line.
@wdu9 @AMonninger @kennetheva
The text was updated successfully, but these errors were encountered: