-
-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markov solver in DCL-Dev-1 #32
Comments
Did I have cubic interpolation in my version? I know there was a bit of new
On Apr 21, 2016 8:57 AM, "dclow" notifications@github.com wrote:
|
You did. I think I can get to the point where the new version returns the same answer as the old version, if told to use cubic splines. But if we aren't sure that's the correct answer I might not invest a huge amount of time in it... let's see how hard this turns out to be |
For what it's worth, the reason I didn't find this bug until now was I had set a_size to be much bigger (48), and so the (linear) interpolation results from the new version and the (cubic) results from the old version appeared identical. So that at least is an encouraging sign that the cubic results are right |
I'm pretty sure it's correct, from comparing the results of the linear and
On Thu, Apr 21, 2016 at 9:11 AM, dclow notifications@github.com wrote:
|
The Markov solver is now working correctly after MNW-dev-3 merge. Still requires OOP refactoring based on newest DCL-dev-1 commits, but this might be tricky. |
Already found one bug in DCL-dev-1... the Markov solver uses linear interpolation even when it is supposed to use cubic. I'm working on this now.
The text was updated successfully, but these errors were encountered: