Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use Lognormal.from_mean_std in RiskyAsset forward simulation #1019

Merged
merged 2 commits into from
Jun 21, 2021

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Jun 18, 2021

fixes #1003

  • [x ] Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@project-bot project-bot bot added this to Needs Triage in Issues & PRs Jun 18, 2021
@sbenthall sbenthall requested a review from Mv77 June 18, 2021 14:47
@codecov-commenter
Copy link

Codecov Report

Merging #1019 (4a509fb) into master (085ea3a) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 4a509fb differs from pull request most recent head abc02f2. Consider uploading reports for the commit abc02f2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1019      +/-   ##
==========================================
- Coverage   72.43%   72.42%   -0.02%     
==========================================
  Files          66       66              
  Lines        9871     9867       -4     
==========================================
- Hits         7150     7146       -4     
  Misses       2721     2721              
Impacted Files Coverage Δ
HARK/distribution.py 80.60% <ø> (ø)
HARK/ConsumptionSaving/ConsRiskyAssetModel.py 85.93% <100.00%> (-0.83%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 085ea3a...abc02f2. Read the comment docs.

Copy link
Contributor

@Mv77 Mv77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me

@sbenthall sbenthall merged commit b1e8c29 into econ-ark:master Jun 21, 2021
Issues & PRs automation moved this from Needs Triage to Done Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issues & PRs
  
Done
Development

Successfully merging this pull request may close these issues.

Better documentation and use of lognormal parameters
3 participants