Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move 'cycles' from agent constructor argument to parameter #1031

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

sbenthall
Copy link
Contributor

@sbenthall sbenthall commented Jun 28, 2021

Fixes #1030

  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

@sbenthall sbenthall requested a review from mnwhite June 28, 2021 13:30
@project-bot project-bot bot added this to Needs Triage in Issues & PRs Jun 28, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jun 28, 2021

Codecov Report

Merging #1031 (7efe5b3) into master (18c410d) will decrease coverage by 0.17%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1031      +/-   ##
==========================================
- Coverage   72.41%   72.23%   -0.18%     
==========================================
  Files          66       66              
  Lines        9865     9870       +5     
==========================================
- Hits         7144     7130      -14     
- Misses       2721     2740      +19     
Impacted Files Coverage Δ
HARK/core.py 89.67% <ø> (+0.20%) ⬆️
HARK/ConsumptionSaving/ConsGenIncProcessModel.py 83.18% <100.00%> (-5.90%) ⬇️
HARK/ConsumptionSaving/ConsIndShockModel.py 85.84% <100.00%> (ø)
HARK/ConsumptionSaving/ConsLaborModel.py 82.90% <100.00%> (ø)
HARK/ConsumptionSaving/ConsMarkovModel.py 86.08% <100.00%> (ø)
HARK/ConsumptionSaving/ConsMedModel.py 74.04% <100.00%> (ø)
HARK/ConsumptionSaving/ConsPortfolioModel.py 66.57% <100.00%> (ø)
HARK/ConsumptionSaving/ConsPrefShockModel.py 79.68% <100.00%> (ø)
HARK/ConsumptionSaving/ConsRepAgentModel.py 100.00% <100.00%> (ø)
HARK/ConsumptionSaving/ConsRiskyAssetModel.py 85.93% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c410d...7efe5b3. Read the comment docs.

@sbenthall
Copy link
Contributor Author

ready for review

@mnwhite
Copy link
Contributor

mnwhite commented Jul 1, 2021

Yes, this is what we want.

@mnwhite mnwhite merged commit 321e704 into econ-ark:master Jul 1, 2021
Issues & PRs automation moved this from Needs Triage to Done Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Issues & PRs
  
Done
Development

Successfully merging this pull request may close these issues.

no default cycles value
3 participants