Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows for age-varying interest rate in ConsumptionSaving models #1150

Merged
merged 8 commits into from
Jul 1, 2022

Conversation

alanlujan91
Copy link
Member

@alanlujan91 alanlujan91 commented Jun 21, 2022

This PR allows for interest rate (Rfree) to be "age"-varying in ConsumptionSaving models.

Currently it is only tested in ConsIndShockModel, but it should work on all other models by design.

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

determines whether Rfree is time-varying
create RfreeNow depending on whether it's time-varying
@alanlujan91
Copy link
Member Author

Requesting review from @wdu9. Let me know if this works as you expect!

@codecov-commenter
Copy link

codecov-commenter commented Jun 21, 2022

Codecov Report

Merging #1150 (491f0d5) into master (0171e0d) will increase coverage by 0.00%.
The diff coverage is 71.42%.

@@           Coverage Diff           @@
##           master    #1150   +/-   ##
=======================================
  Coverage   74.06%   74.07%           
=======================================
  Files          70       70           
  Lines       10807    10838   +31     
=======================================
+ Hits         8004     8028   +24     
- Misses       2803     2810    +7     
Impacted Files Coverage Δ
...nsumptionSaving/tests/test_IndShockConsumerType.py 75.86% <57.14%> (+0.78%) ⬆️
HARK/ConsumptionSaving/ConsIndShockModel.py 85.40% <85.71%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0171e0d...491f0d5. Read the comment docs.

@wdu9
Copy link
Collaborator

wdu9 commented Jun 22, 2022

Requesting review from @wdu9. Let me know if this works as you expect!

Looks great! Thanks!

@alanlujan91 alanlujan91 mentioned this pull request Jun 23, 2022
3 tasks
@llorracc llorracc merged commit c433366 into econ-ark:master Jul 1, 2022
@alanlujan91 alanlujan91 deleted the cism_Rfree branch July 1, 2022 17:16
@sbenthall sbenthall added this to the 0.13.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants