Rename pmf and X

[alanlujan91]

See #1051, #1159

[codecov-commenter]

Codecov Report

Merging #1164 (c3262ef) into master (b344850) will not change coverage.
The diff coverage is 82.12%.

@@           Coverage Diff           @@
##           master    #1164   +/-   ##
=======================================
  Coverage   73.33%   73.33%           
=======================================
  Files          72       72           
  Lines       11387    11387           
=======================================
  Hits         8351     8351           
  Misses       3036     3036           

Impacted Files	Coverage Δ
HARK/ConsumptionSaving/ConsRiskyAssetModel.py	40.59% <0.00%> (ø)
HARK/ConsumptionSaving/ConsAggShockModel.py	89.64% <63.33%> (ø)
HARK/ConsumptionSaving/ConsRiskyContribModel.py	79.42% <75.00%> (ø)
HARK/core.py	91.47% <85.71%> (ø)
HARK/distribution.py	86.22% <86.11%> (ø)
HARK/ConsumptionSaving/ConsIndShockModel.py	85.34% <100.00%> (ø)
HARK/ConsumptionSaving/ConsIndShockModelFast.py	51.05% <100.00%> (ø)
HARK/ConsumptionSaving/ConsLaborModel.py	82.90% <100.00%> (ø)
HARK/ConsumptionSaving/ConsMarkovModel.py	85.83% <100.00%> (ø)
HARK/ConsumptionSaving/ConsMedModel.py	74.04% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sbenthall]

I like it. Changelog update?

[alanlujan91]

PR econ-ark/DemARK#187 fixes DemARK's after this PR is merged.

[llorracc]

@alanlujan91, @MridulS

Do we have a way to check whether any REMARKs might be broken?

In principle, REMARKs should all have version control on them so should not break. In practice, I doubt that they all do (or do so correctly).

[llorracc]

@MridulS,

To broaden my prior point, if I'm not mistaken, at the moment our procedure is to run DemARK checks nightly by running against the master branch of the development HARK repo. Would it be easy to set things up so that the DemARKs are also tested against any new PR's? Or, at least, could we somehow automatically remind the poster of a new PR to check DemARKs (and maybe REMARKs)?