Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform endpoints #1180

Merged
merged 7 commits into from
Nov 10, 2022
Merged

Conversation

alanlujan91
Copy link
Member

@alanlujan91 alanlujan91 commented Oct 11, 2022

Addresses: #1178

Please ensure your pull request adheres to the following guidelines:

  • Tests for new functionality/models or Tests to reproduce the bug-fix in code.
  • Updated documentation of features that add new functionality.
  • Update CHANGELOG.md with major/minor changes.

include endpoints in approximation
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 72.79% // Head: 72.81% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (4e56ac4) compared to base (1539850).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1180      +/-   ##
==========================================
+ Coverage   72.79%   72.81%   +0.01%     
==========================================
  Files          72       72              
  Lines       11793    11800       +7     
==========================================
+ Hits         8585     8592       +7     
  Misses       3208     3208              
Impacted Files Coverage Δ
HARK/distribution.py 82.57% <100.00%> (+0.10%) ⬆️
HARK/tests/test_distribution.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sbenthall
Copy link
Contributor

Merge conflict and CHANGELOG update please

)

if endpoint:
atoms = np.linspace(self.bot, self.top, N)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these points equiprobable with the endpoints included, and if not, how can the pmv be accurately formed?

@sbenthall
Copy link
Contributor

@llorracc : what about infinitessimally sized point masses for the endpoints?

@alanlujan91
Copy link
Member Author

#todo for other distributions adding endpoints (truncated lognormal)

@alanlujan91 alanlujan91 merged commit 20645e2 into econ-ark:master Nov 10, 2022
@sbenthall sbenthall added this to the 0.13.0 milestone Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants