perfect foresight model data #1347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1347 +/- ##
==========================================
- Coverage 73.04% 73.02% -0.02%
==========================================
Files 78 79 +1
Lines 13374 13377 +3
==========================================
Hits 9769 9769
- Misses 3605 3608 +3
☔ View full report in Codecov by Sentry. |
|
add fischer two period: But @mnwhite should this be a 'different model'? |
|
I've added CHANGELOG and automated tests are meaningless in this case. This PR has no new functionality but is needed for further testing of #1296 (Generic monte carlo simulation). @mnwhite @alanlujan91 could you please review and, if passing, merge? |
alanlujan91
approved these changes
Sep 27, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to demonstrate how we could proceed with #1346 by writing lightweight model definition files in pure Python.
Models defined in this way could then be the source of equations that are integrated into AgentType (see #1292 ) or used as an input to generic Monte Carlo simulation (#1296) or solution algorithms (#1286).
I'm not committed to the form in this PR, but it reflects the kind of information that's useful for downstream algorithms (as in (#1296) and is otherwise quite minimal. I'd argue that any problem representation we develop in YAML will be parsed into something quite like this, so this is a fine start which we could then expand upon as needed.