Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Bump up min python version to 3.10 to align with SPEC 0 #1415

Merged
merged 17 commits into from
Apr 29, 2024

Conversation

MridulS
Copy link
Member

@MridulS MridulS commented Apr 23, 2024

We should probably look into loosely following https://scientific-python.org/specs/spec-0000

Numba supports python 3.12 too, so hopefully we should be able to bump up things all around.

The coverage action is broken, it doesn't really upload anything (returns a 404 error), we should probably remove it unless someone is actively monitoring it?

@MridulS MridulS changed the title MAINT: bump up to py3.12 for doc build MAINT: Bump up min python version to 3.10 to align with SPEC 0 Apr 23, 2024
@MridulS
Copy link
Member Author

MridulS commented Apr 23, 2024

The test failures are coming from the changes in interpolation.py

@alanlujan91
Copy link
Member

So we still can't bump up to 3.12? Do we know if these are fixable errors or does interpolation.py still not allow us to move up?

@alanlujan91
Copy link
Member

can you take a look at this when you have time @Mv77?

@Mv77
Copy link
Contributor

Mv77 commented Apr 24, 2024

I'd be happy to.

But to make sure I have the right version of everything, is there any yaml file with the environment that I should use while checking the tests?

@alanlujan91
Copy link
Member

pip install -e . should install all the dependencies, we got rid of environment.yml files

@Mv77
Copy link
Contributor

Mv77 commented Apr 24, 2024

I'll run that in a clean python 3.12 env and report back.

@Mv77
Copy link
Contributor

Mv77 commented Apr 24, 2024

Can confirm all econforge tests fail locally. Debugging.

@Mv77
Copy link
Contributor

Mv77 commented Apr 24, 2024

Here's a PR to @MridulS 's branch that fixes the issue.
#1419

Pablo changed the name of a parameter in one of the main functions.

All tests pass locally except for an unrelated one, @sbenthall

File "/home/mvg/GitHub/HARK/HARK/tests/test_model.py", line 39, in test_init
    self.assertEquals(self.test_block_A.name, "test block A")
    ^^^^^^^^^^^^^^^^^
AttributeError: 'test_DBlock' object has no attribute 'assertEquals'. Did you mean: 'assertEqual'?

@Mv77
Copy link
Contributor

Mv77 commented Apr 25, 2024

It looks like there are now unrelated errors having to do with assertions?

It is strange that I did not get those locally.

@Mv77
Copy link
Contributor

Mv77 commented Apr 26, 2024

#1420 fixes a typo that is making the 3.12 versions fail.

What I can't figure out is why 3.11 is failing. There are some failures related to properties of numpy arrays that I can not reproduce locally on a fresh 3.11 env.

@Mv77
Copy link
Contributor

Mv77 commented Apr 26, 2024

Do they fail locally for you @alanlujan91 ?

@alanlujan91
Copy link
Member

Do they fail locally for you @alanlujan91 ?

no, but they are failing on the mac tests and I have a windows, so I am trying to "guess" what a mac would like, we'll see if it passes!

@Mv77
Copy link
Contributor

Mv77 commented Apr 26, 2024

MAC: It just doesn't work^{TM}

(works fine in my local ubuntu too)

@alanlujan91
Copy link
Member

@Mv77 I think i'm getting close, only 1 failing test on mac now!

@alanlujan91
Copy link
Member

UGHHH everything is passing except for coverage

I agree with @MridulS that we should remove it

@alanlujan91
Copy link
Member

I think this will let us finally bump to python 3.12!

Thank you @MridulS and @Mv77!

@mnwhite please review and merge when appropriate

@mnwhite mnwhite merged commit 8e70825 into master Apr 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants