Fix EconForge interpolation tests [WIP] #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Want to show that these tests are suddenly failing with no change on our part.
It looks like numba pushed a new version on June 13, which could be the culprit.
|
Aaaand I misspelled "numba" in the commit name. |
|
All tests and examples are passing, will merge to master momentarily. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The EconForge interpolation tests are failing, but nothing in our code has changed. As of right now, this branch only exists to demonstrate the problem: The latest commit on the master branch passed its tests, but now a new branch with only a trivial change (adding a period to a comment) fails them.
This branch will be used to fix the tests once we know what's going on.